[PATCH] drm/bochs: use simple display pipe

Sam Ravnborg sam at ravnborg.org
Wed Apr 10 21:22:40 UTC 2019


Hi Gerd.

>  
>  #include <drm/drm_gem.h>
>  
> @@ -69,9 +70,8 @@ struct bochs_device {
>  	struct edid *edid;
>  
>  	/* drm */
> -	struct drm_device  *dev;
> -	struct drm_crtc crtc;
> -	struct drm_encoder encoder;
> +	struct drm_device *dev;
> +	struct drm_simple_display_pipe pipe;
>  	struct drm_connector connector;

Have you considered to embed drm_device in the bochs_device struct?
This is the new way to do it.

This should likely be a follow-up patch...

Rest of the patch looked good.
Did not do a proper review but you can add my:
Acked-by: Sam Ravnborg <sam at ravnborg.org>

	Sam


More information about the dri-devel mailing list