[PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case

[Inki Dae]

Hi Sam,

19. 4. 15. 오후 12:17에 Sam Ravnborg 이(가) 쓴 글:
> Hi Inki
> 
> On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote:
>> This patch makes error messages to be printed out using DRM_ERROR
>> instead of DRM_INFO.
>>
>> Signed-off-by: Inki Dae <inki.dae at samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> index 786a8ee..78427ec 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> @@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
>>  	u32 clkdiv;
>>  
>>  	if (mode->clock == 0) {
>> -		DRM_INFO("Mode has zero clock value.\n");
>> +		DRM_ERROR("Mode has zero clock value.\n");
> 
> To give the logs a more precise info on where is comes from you
> could consider to use:
> 
> 		DRM_DEV_ERROR(ctx->dev, "Mode has zero clock value.\n");

Thanks for comment and looks better. :)
This patch corrects the use of log macro so I will make and push a new patch - which changes all existing DRM_ERROR macros to DRM_DEV_ERROR - on top of this patch series.

Thanks,
Inki Dae

> 
> Likewise below.
> 
> 
> 	Sam
> 
>