[PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only

Daniel Vetter daniel at ffwll.ch
Tue Apr 16 07:42:07 UTC 2019


On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat wrote:
> Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
> user-space, so no point exposing it otherwise.
> 
> Signed-off-by: Deepak Rawat <drawat at vmware.com>
> Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update")

Makes sense, probably good if we add Cc: stable at vger.kernel.org too

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

btw, want drm-misc commit rights to push this? Assuming you'd then push
vmware drm patches in general ofc. See

https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html

Cheers, Daniel

> ---
>  drivers/gpu/drm/drm_mode_config.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 4a1c2023ccf0..1a346ae1599d 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -297,8 +297,9 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
>  		return -ENOMEM;
>  	dev->mode_config.prop_crtc_id = prop;
>  
> -	prop = drm_property_create(dev, DRM_MODE_PROP_BLOB, "FB_DAMAGE_CLIPS",
> -				   0);
> +	prop = drm_property_create(dev,
> +			DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> +			"FB_DAMAGE_CLIPS", 0);
>  	if (!prop)
>  		return -ENOMEM;
>  	dev->mode_config.prop_fb_damage_clips = prop;
> -- 
> 2.21.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list