[PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown
Marc Zyngier
marc.zyngier at arm.com
Wed Apr 17 10:05:10 UTC 2019
Hi Heiko,
On 02/04/2019 12:37, Heiko Stuebner wrote:
> From: Vicente Bergas <vicencb at gmail.com>
>
> As explained by Robin Murphy:
>> the IOMMU shutdown disables paging, so if the VOP is still
>> scanning out then that will result in whatever IOVAs it was using now going
>> straight out onto the bus as physical addresses.
>
> We had a more radical approach before in commit
> 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec")
> but that resulted in new warnings and oopses on shutdown on rk3399
> chromeos devices.
>
> So second try is resurrecting Vicentes shutdown change which should
> achieve the same result but in a less drastic way.
>
> Fixes: 63238173b2fa ("Revert drm/rockchip: Allow driver to be shutdown on reboot/kexec")
> Cc: Jeffy Chen <jeffy.chen at rock-chips.com>
> Cc: Robin Murphy <robin.murphy at arm.com>
> Cc: Marc Zyngier <marc.zyngier at arm.com>
> Cc: Brian Norris <briannorris at chromium.org>
> Cc: Doug Anderson <dianders at chromium.org>
> Cc: stable at vger.kernel.org
> Suggested-by: JeffyChen <jeffy.chen at rock-chips.com>
> Suggested-by: Robin Murphy <robin.murphy at arm.com>
> Signed-off-by: Vicente Bergas <vicencb at gmail.com>
> [adapted commit message to explain the history]
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
Sorry it took so long to test this. I've just given it a go on kevin,
and managed to kexec into a secondary kernel. So FWIW:
Acked-by: Marc Zyngier <marc.zyngier at arm.com>
M.
--
Jazz is not dead. It just smells funny...
More information about the dri-devel
mailing list