[PATCH] drm/amdgpu: fix drm leases being broken on radv

Michel Dänzer michel at daenzer.net
Thu Apr 18 08:52:53 UTC 2019


On 2019-04-18 10:26 a.m., Daniel Vetter wrote:
> 
> Ok correction: amd has stuck out in the past too, there was some vblank vs
> pageflip stuff where we needed to do some pretty clever tricks to both
> have the new stricter semantics for everyone, while keeping the amd ddx
> happy still. This aint new at all, we fixed up the regressions and moved
> on.

That sounds like something I would have been involved in, but I'm not
sure what you mean...

I fixed the amdgpu/radeon kernel drivers to obey the general KMS rules
for vblank vs page flips, and added DRM_MODE_PAGE_FLIP_TARGET to allow
userspace to take advantage of our hardware's capabilities to avoid
delaying a page flip by one refresh cycle in some cases. That's all.


> tldr; You're categorical rejection doesn't make sense to me.
> Slightly over the top, but this feels like gut reaction to radv being a
> thorn for amd.

That's a weird insinuation. If RADV was a "thorn for AMD", surely we'd
be having a party about this regression instead of insisting that it be
fixed thoroughly.


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the dri-devel mailing list