[patch V2 01/29] tracing: Cleanup stack trace code

Steven Rostedt rostedt at goodmis.org
Thu Apr 18 21:24:43 UTC 2019


On Thu, 18 Apr 2019 23:14:45 +0200 (CEST)
Thomas Gleixner <tglx at linutronix.de> wrote:

> On Thu, 18 Apr 2019, Josh Poimboeuf wrote:
> 
> > On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote:  
> > > - Remove the extra array member of stack_dump_trace[]. It's not required as
> > >   the stack tracer stores at max array size - 1 entries so there is still
> > >   an empty slot.  
> > 
> > What is the empty slot used for?  
> 
> I was trying to find an answer but failed. Maybe it's just historical
> leftovers or Steven knows where the magic is in this maze.
>

I believe it was for historical leftovers (there was a time it was
required), and left there for "paranoid" sake. But let me apply the
patch and see if it is really needed.

-- Steve


More information about the dri-devel mailing list