[PATCH] Revert "drm/virtio: drop prime import/export callbacks"

[Chia-I Wu]

On Fri, Apr 19, 2019 at 9:21 AM Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
> On Fri, 19 Apr 2019 at 16:57, Marc-André Lureau
> <marcandre.lureau at redhat.com> wrote:
> >
> > This patch does more harm than good, as it breaks both Xwayland and
> > gnome-shell with X11.
> >
> > Xwayland requires DRI3 & DRI3 requires PRIME.
> >
> > X11 crash for obscure double-free reason which are hard to debug
> > (starting X11 by hand doesn't trigger the crash).
> >
> > I don't see an apparent problem implementing those stub prime
> > functions, they may return an error at run-time, and it seems to be
> > handled fine by GNOME at least.
> >
> > Please consider a revert.
> >
> > This reverts commit b318e3ff7ca065d6b107e424c85a63d7a6798a69.
> >
> > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > Cc: Dave Airlie <airlied at redhat.com>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
>
> The DRI3 code extensively uses prime_handle_to_fd and
> prime_fd_to_handle for self-import.
>
> Fwiw the patch is:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
We also use Xwayland and will be helped by the revert.

I believe the cap was removed because the driver only supports
self-import.  But the driver only runs inside VMs where there is no(?)
other dma-buf clients, and it handles runtime errors fine even if
there are, I would also like to see this revert be considered.

>
> -Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel