[PATCH v3 00/11] drm/fb-helper: Move modesetting code to drm_client

Noralf Trønnes noralf at tronnes.org
Sat Apr 20 17:24:32 UTC 2019



Den 20.04.2019 12.45, skrev Noralf Trønnes:
> This moves the modesetting code from drm_fb_helper to drm_client so it
> can be shared by all internal clients.
> 
> Changes this time:
> - Use full drm_client_init/release for the modesets (Daniel Vetter)
> - drm_client_for_each_modeset: use lockdep_assert_held (Daniel Vetter)
> - Hook up to Documentation/gpu/drm-client.rst (Daniel Vetter)
> 

I got Fi.CI.IGT failures on this one:

  * igt at kms_fbcon_fbt@psr:
    - shard-skl:          PASS -> FAIL

  * igt at kms_fbcon_fbt@psr-suspend:
    - shard-iclb:         PASS -> FAIL +1
    - shard-skl:          NOTRUN -> FAIL

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12850/
https://patchwork.freedesktop.org/series/58597/

The previous version of this series reported success:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12720/
But AFAICT those fbcon tests didn't succeed when I look at the details.

I'd appreciate if someone with Intel CI knowledge could have a look at this.

Noralf.

> Noralf.
> 
> Noralf Trønnes (11):
>   drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()
>   drm/fb-helper: Avoid race with DRM userspace
>   drm/fb-helper: No need to cache rotation and sw_rotations
>   drm/fb-helper: Remove drm_fb_helper_crtc->{x,y,desired_mode}
>   drm/fb-helper: Remove drm_fb_helper_crtc
>   drm/fb-helper: Prepare to move out commit code
>   drm/fb-helper: Move out commit code
>   drm/fb-helper: Remove drm_fb_helper_connector
>   drm/fb-helper: Prepare to move out modeset config code
>   drm/fb-helper: Move out modeset config code
>   drm/client: Hack: Add bootsplash example
> 
>  Documentation/gpu/drm-client.rst     |    3 +
>  Documentation/gpu/todo.rst           |   10 +
>  drivers/gpu/drm/Kconfig              |    5 +
>  drivers/gpu/drm/Makefile             |    3 +-
>  drivers/gpu/drm/drm_atomic.c         |  168 ++++
>  drivers/gpu/drm/drm_atomic_helper.c  |  164 ---
>  drivers/gpu/drm/drm_auth.c           |   20 +
>  drivers/gpu/drm/drm_bootsplash.c     |  362 +++++++
>  drivers/gpu/drm/drm_client.c         |   17 +-
>  drivers/gpu/drm/drm_client_modeset.c | 1085 ++++++++++++++++++++
>  drivers/gpu/drm/drm_crtc_internal.h  |    5 +
>  drivers/gpu/drm/drm_drv.c            |    4 +
>  drivers/gpu/drm/drm_fb_helper.c      | 1381 +++-----------------------
>  drivers/gpu/drm/drm_internal.h       |    2 +
>  include/drm/drm_atomic_helper.h      |    4 -
>  include/drm/drm_client.h             |   49 +
>  include/drm/drm_fb_helper.h          |  102 +-
>  17 files changed, 1864 insertions(+), 1520 deletions(-)
>  create mode 100644 drivers/gpu/drm/drm_bootsplash.c
>  create mode 100644 drivers/gpu/drm/drm_client_modeset.c
> 


More information about the dri-devel mailing list