[RFC][PATCH 5/5] libdrm: omap: Add DRM_RDWR flag to dmabuf export

Christian König ckoenig.leichtzumerken at gmail.com
Tue Apr 23 12:56:17 UTC 2019


Am 23.04.19 um 12:26 schrieb Emil Velikov:
> On Sat, 20 Apr 2019 at 05:25, John Stultz <john.stultz at linaro.org> wrote:
>> From: Hemant Hariyani <hemanthariyani at ti.com>
>>
>> Allows mmap on dmabuf fd with MAP_SHARED and PROT_WRITE.
>>
>> This fixes boot failures caused due to mmap() returning error
>>
> Commit message is quite meh - xf86-video-omap does not use the API, so
> things should work (tm) ;-)
> Joking aside - Android and closed source user-space drivers are used,
> so please mention that.
>
> Although I'd stick with Rob's input - he is the principal author of this code.

IIRC we had the same problem in amdgpu some time ago, so in general the 
patch looks correct to me.

Christian.

>
> -Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



More information about the dri-devel mailing list