[PATCH 06/12] drm/legacy: move map_hash create/destroy into inlines
Sam Ravnborg
sam at ravnborg.org
Tue Apr 23 19:48:44 UTC 2019
Hi Dave.
Micro nit..
On Tue, Apr 23, 2019 at 12:00:35PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This allows them to be removed later.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
> drivers/gpu/drm/drm_drv.c | 7 +++----
> drivers/gpu/drm/drm_legacy.h | 10 ++++++++++
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 15b0fd5adaaf..18f45f9a955c 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -692,10 +692,9 @@ int drm_dev_init(struct drm_device *dev,
> if (ret)
> goto err_minors;
>
> - ret = drm_ht_create(&dev->map_hash, 12);
> + ret = drm_legacy_create_map_hash(dev);
> if (ret)
> goto err_minors;
> -
> drm_legacy_ctxbitmap_init(dev);
Removal of empty line does not make code easier to read, and
an unrelated change.
As I said - micro nit.
Sam
More information about the dri-devel
mailing list