[PATCH] drm/stm: ltdc: use DRM_WARN for fifo & transfer error messages

[Benjamin Gaignard]

Le lun. 1 avr. 2019 à 11:20, Philippe CORNU <philippe.cornu at st.com> a écrit :
>
> Dear Yannick,
> Fully agree with this approach,
>
> Acked-by: Philippe Cornu <philippe.cornu at st.com>
>

Applied on drm-misc-next,
Thanks,
Benjamin

> Philippe :-)
>
> On 3/29/19 4:49 PM, Yannick Fertré wrote:
> > From: Philippe Cornu <philippe.cornu at st.com>
> >
> > Use DRM_WARN() instead of DRM_DEBUG_DRIVER() to better
> > inform the user in case of fifo underruns or
> > transfer errors.
> >
> > Signed-off-by: Philippe Cornu <philippe.cornu at st.com>
> > ---
> >   drivers/gpu/drm/stm/ltdc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> > index b1741a9..15d8a02 100644
> > --- a/drivers/gpu/drm/stm/ltdc.c
> > +++ b/drivers/gpu/drm/stm/ltdc.c
> > @@ -822,11 +822,11 @@ static void ltdc_plane_atomic_update(struct drm_plane *plane,
> >
> >       mutex_lock(&ldev->err_lock);
> >       if (ldev->error_status & ISR_FUIF) {
> > -             DRM_DEBUG_DRIVER("Fifo underrun\n");
> > +             DRM_WARN("ltdc fifo underrun: please verify display mode\n");
> >               ldev->error_status &= ~ISR_FUIF;
> >       }
> >       if (ldev->error_status & ISR_TERRIF) {
> > -             DRM_DEBUG_DRIVER("Transfer error\n");
> > +             DRM_WARN("ltdc transfer error\n");
> >               ldev->error_status &= ~ISR_TERRIF;
> >       }
> >       mutex_unlock(&ldev->err_lock);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel