[drm:drm-legacy-cleanup 17/24] drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?

Dan Carpenter dan.carpenter at oracle.com
Wed Apr 24 14:10:09 UTC 2019


tree:   git://people.freedesktop.org/~airlied/linux.git drm-legacy-cleanup
head:   ee22f76306a68359c33809f8895eff603e71584b
commit: 058ca50ce3f1d40dac4d918a91684b0af4a0c468 [17/24] drm/legacy: move lock cleanup for master into lock file (v2)

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
smatch warnings:
drivers/gpu/drm/drm_lock.c:359 drm_legacy_lock_master_cleanup() warn: curly braces intended?

git remote add drm git://people.freedesktop.org/~airlied/linux.git
git remote update drm
git checkout 058ca50ce3f1d40dac4d918a91684b0af4a0c468
vim +359 drivers/gpu/drm/drm_lock.c

058ca50c Dave Airlie 2019-04-23  350  
058ca50c Dave Airlie 2019-04-23  351  void drm_legacy_lock_master_cleanup(struct drm_device *dev, struct drm_master *master)
058ca50c Dave Airlie 2019-04-23  352  {
058ca50c Dave Airlie 2019-04-23  353  	if (!drm_core_check_feature(dev, DRIVER_LEGACY))
058ca50c Dave Airlie 2019-04-23  354  		return;
058ca50c Dave Airlie 2019-04-23  355  
058ca50c Dave Airlie 2019-04-23  356  	/*
058ca50c Dave Airlie 2019-04-23  357  	 * Since the master is disappearing, so is the
058ca50c Dave Airlie 2019-04-23  358  	 * possibility to lock.
058ca50c Dave Airlie 2019-04-23 @359  	 */	mutex_lock(&dev->struct_mutex);
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This should be moved to the next line.  At first I thought it was part
of the comment.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


More information about the dri-devel mailing list