[PATCH libdrm] xf86drm: Fix possible memory leak with drmModeGetPropertyPtr()

Seung-Woo Kim sw0312.kim at samsung.com
Mon Apr 29 09:10:52 UTC 2019


In drmModeGetPropertyPtr(), from upper error path, it calls free
but with just next error path, it does not call. Fix the possible
memory leak.

Signed-off-by: Seung-Woo Kim <sw0312.kim at samsung.com>
---
 xf86drmMode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xf86drmMode.c b/xf86drmMode.c
index c878d9e..207d7be 100644
--- a/xf86drmMode.c
+++ b/xf86drmMode.c
@@ -650,7 +650,7 @@ drm_public drmModePropertyPtr drmModeGetProperty(int fd, uint32_t property_id)
 	}
 
 	if (!(r = drmMalloc(sizeof(*r))))
-		return NULL;
+		goto err_allocs;
 
 	r->prop_id = prop.prop_id;
 	r->count_values = prop.count_values;
-- 
1.7.4.1



More information about the dri-devel mailing list