[PATCH 1/2] drm/omap: dmm_tiler: Use dmaengine_prep_dma_memcpy() for i878 workaround

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Aug 4 12:38:15 UTC 2019


Hi Peter,

Thank you for the patch.

On Wed, Jul 31, 2019 at 12:42:32PM +0300, Peter Ujfalusi wrote:
> Instead of dma_dev->device_prep_dma_memcpy() use the existing macro to
> prepare the memcpy.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 252f5ebb1acc..77728eaa1a6f 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -82,12 +82,11 @@ static const u32 reg[][4] = {
>  
>  static int dmm_dma_copy(struct dmm *dmm, dma_addr_t src, dma_addr_t dst)
>  {
> -	struct dma_device *dma_dev = dmm->wa_dma_chan->device;
>  	struct dma_async_tx_descriptor *tx;
>  	enum dma_status status;
>  	dma_cookie_t cookie;
>  
> -	tx = dma_dev->device_prep_dma_memcpy(dmm->wa_dma_chan, dst, src, 4, 0);
> +	tx = dmaengine_prep_dma_memcpy(dmm->wa_dma_chan, dst, src, 4, 0);
>  	if (!tx) {
>  		dev_err(dmm->dev, "Failed to prepare DMA memcpy\n");
>  		return -EIO;

-- 
Regards,

Laurent Pinchart


More information about the dri-devel mailing list