[PATCH 2/2] Revert "drm/panfrost: Use drm_gem_map_offset()"

Daniel Vetter daniel at ffwll.ch
Wed Aug 7 20:59:52 UTC 2019

On Wed, Aug 07, 2019 at 04:59:51PM +0100, Emil Velikov wrote:
> On Wed, 7 Aug 2019 at 15:53, Sean Paul <sean at poorly.run> wrote:
> >
> > From: Rob Herring <robh at kernel.org>
> >
> > This reverts commit 583bbf46133c726bae277e8f4e32bfba2a528c7f.
> >
> > Turns out we need mmap to work on imported BOs even if the current code
> > is buggy.
> >
> Personally I would have mentioned a use case where imported BOs are used.
> > Signed-off-by: Rob Herring <robh at kernel.org>
> > Signed-off-by: Sean Paul <sean at poorly.run>
> Regardless of the above nitpick, with the patch order fixed the series is:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> ... in case you haven't picked it already.

Yeah a follow-up patch to add a comment here about why exactly this went
all kaboom, plus which userspace (since panfrost is moving fast) would be
real nice here.

Atm we need to hope someone does a git blame on this before the break this
again, which seems a bit hopeful ...
Daniel Vetter
Software Engineer, Intel Corporation

More information about the dri-devel mailing list