[PATCH v4 1/1] drm/syncobj: add sideband payload
Chris Wilson
chris at chris-wilson.co.uk
Fri Aug 9 12:38:14 UTC 2019
Quoting Chris Wilson (2019-08-09 12:58:51)
> Quoting Lionel Landwerlin (2019-08-09 12:30:30)
> > + if (flags & I915_DRM_SYNCOBJ_BINARY_ITEM_VALUE_READ) {
> > + copy_to_user(&values[i], &syncobjs[i]->binary_payload, sizeof(values[i]));
> > + ret = ret ? -EFAULT : 0;
>
> More magic.
>
> if (put_user(&syncobjs[i]->binary_payload, &values[i]))
> return -EFAULT;
(break not yet)
Should just be put_user(syncobjs[i]->binary_payload, &values[i])
The value of, not its address.
-Chris
More information about the dri-devel
mailing list