[PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

[Noralf Trønnes]

Den 11.08.2019 17.24, skrev Sam Ravnborg:
> Hi Noralf.
> 
> Most feedback on this driver was covered in comment to 1/4.
> Only a few things caught my eye.
> 
> On Thu, Aug 01, 2019 at 03:52:47PM +0200, Noralf Trønnes wrote:
>> Move the driver to drm/panel and take advantage of the new panel support
>> in drm_mipi_dbi. Change the file name to match the naming standard in
>> drm/panel. The DRM driver name is kept since it is ABI.
>>
>> Add missing MAINTAINERS entry.
>>
>> Cc: David Lechner <david at lechnology.com>
>> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
>> ---
>>  MAINTAINERS                                   |   7 +
>>  drivers/gpu/drm/panel/Kconfig                 |  12 ++
>>  drivers/gpu/drm/panel/Makefile                |   1 +
>>  .../panel-ilitek-ili9341.c}                   | 174 ++++++++++--------
>>  drivers/gpu/drm/tiny/Kconfig                  |  13 --
>>  drivers/gpu/drm/tiny/Makefile                 |   1 -
>>  6 files changed, 113 insertions(+), 95 deletions(-)
>>  rename drivers/gpu/drm/{tiny/ili9341.c => panel/panel-ilitek-ili9341.c} (66%)
>>
>> +
>> +struct ili9341 {
>> +	struct mipi_dbi_dev dbidev; /* This must be the first entry */
> 
> Can we avoid the need for this to be the first entry?
> 

That would require this driver to have a custom drm_driver->release and
pass that into the DEFINE_DRM_MIPI_DBI_PANEL_DRIVER macro.

Having it as the first entry, mipi_dbi_release() will suffice.
Simplifying things.

> 
>> -static struct drm_driver ili9341_driver = {
>> -	.driver_features	= DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
>> -	.fops			= &ili9341_fops,
>> -	.release		= mipi_dbi_release,
>> -	DRM_GEM_CMA_VMAP_DRIVER_OPS,
>> -	.debugfs_init		= mipi_dbi_debugfs_init,
>> -	.name			= "ili9341",
>> -	.desc			= "Ilitek ILI9341",
>> -	.date			= "20180514",
>> -	.major			= 1,
>> -	.minor			= 0,
> 
>> +DEFINE_DRM_MIPI_DBI_PANEL_DRIVER(ili9341, "Ilitek ILI9341", "20180514");
> Update the date. This is a major change so let it be refelcted in the
> date.
> 

I guess that makes sense. I don't know what this date field is used for
though.

Noralf.