[PATCH 28/60] drm/omap: Factor out display type to connector type conversion

[Tomi Valkeinen]

On 07/07/2019 21:19, Laurent Pinchart wrote:
> Move the code that computes the DRM connector type for the
> omapdss_device display type to a new omapdss_device_connector_type()
> function for later reuse.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>   drivers/gpu/drm/omapdrm/dss/base.c       | 23 +++++++++++++++++++++++
>   drivers/gpu/drm/omapdrm/dss/omapdss.h    |  1 +
>   drivers/gpu/drm/omapdrm/omap_connector.c | 19 +------------------
>   3 files changed, 25 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/base.c b/drivers/gpu/drm/omapdrm/dss/base.c
> index a1970b9db6ab..cae5687822e2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/base.c
> +++ b/drivers/gpu/drm/omapdrm/dss/base.c
> @@ -285,6 +285,29 @@ void omapdss_device_post_disable(struct omap_dss_device *dssdev)
>   }
>   EXPORT_SYMBOL_GPL(omapdss_device_post_disable);
>   
> +unsigned int omapdss_device_connector_type(enum omap_display_type type)
> +{
> +	switch (type) {
> +	case OMAP_DISPLAY_TYPE_HDMI:
> +		return DRM_MODE_CONNECTOR_HDMIA;
> +	case OMAP_DISPLAY_TYPE_DVI:
> +		return DRM_MODE_CONNECTOR_DVID;
> +	case OMAP_DISPLAY_TYPE_DSI:
> +		return DRM_MODE_CONNECTOR_DSI;
> +	case OMAP_DISPLAY_TYPE_DPI:
> +	case OMAP_DISPLAY_TYPE_DBI:
> +		return DRM_MODE_CONNECTOR_DPI;
> +	case OMAP_DISPLAY_TYPE_VENC:
> +		/* TODO: This could also be composite */
> +		return DRM_MODE_CONNECTOR_SVIDEO;
> +	case OMAP_DISPLAY_TYPE_SDI:
> +		return DRM_MODE_CONNECTOR_LVDS;
> +	default:
> +		return DRM_MODE_CONNECTOR_Unknown;
> +	}
> +}
> +EXPORT_SYMBOL_GPL(omapdss_device_connector_type);

Why do we need to export this? In the end enum omap_display_type should 
go away or be private to omapdrm, right?

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki