[PATCH v4 0/9] DRM panel drivers for omapdrm
sam at ravnborg.org
Wed Aug 14 20:28:01 UTC 2019
On Wed, Aug 14, 2019 at 06:44:26PM +0200, Sam Ravnborg wrote:
> Hi Laurent.
> On Tue, Aug 13, 2019 at 11:10:52PM +0300, Laurent Pinchart wrote:
> > Hello everybody,
> > This patch series adds DT bindings and drivers for 6 panels used by
> > omapdrm. They are meant to replace the corresponding omapdrm-specific
> > drivers from drivers/gpu/drm/omapdrm/displays/ that will be removed in a
> > subsequent patch series, once the omapdrm driver switches fully to the
> > drm_panel API.
> > There's nothing very special here. The first three patches add DT vendor
> > prefixes and DT bindings. The last six patches add new panel drivers.
> > Please see individual patches for changelogs. Sam, all the patches have
> > now been acked (resulting in a TODO list in 7/9 and a rework of 8/9).
> > Would you merge this in drm-misc ?
> > The patches are based on top of drm-misc-next and can be found at
> > git://linuxtv.org/pinchartl/media.git omapdrm/panels
> > Laurent Pinchart (9):
> > dt-bindings: Add vendor prefix for LG Display
> > dt-bindings: Add legacy 'toppoly' vendor prefix
> > dt-bindings: display: panel: Add bindings for NEC NL8048HL11 panel
> > drm/panel: Add driver for the LG Philips LB035Q02 panel
> > drm/panel: Add driver for the NEC NL8048HL11 panel
> > drm/panel: Add driver for the Sharp LS037V7DW01 panel
> > drm/panel: Add driver for the Sony ACX565AKM panel
> > drm/panel: Add driver for the Toppoly TD028TTEC1 panel
> > drm/panel: Add driver for the Toppoly TD043MTEA1 panel
> dim was not too happy with the patches.
> checkpatch --strict triggers too much:
> drm/panel: Add driver for the LG Philips LB035Q02 panel
> -:24: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
> #24: FILE: drivers/gpu/drm/panel/Kconfig:106:
> +config DRM_PANEL_LG_LB035Q02
> -:235: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!lcd"
> #235: FILE: drivers/gpu/drm/panel/panel-lg-lb035q02.c:183:
> + if (lcd == NULL)
> drm/panel: Add driver for the NEC NL8048HL11 panel
> -:23: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
> #23: FILE: drivers/gpu/drm/panel/Kconfig:122:
> +config DRM_PANEL_NEC_NL8048HL11
> -:47: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
> new file mode 100644
> -:136: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
> #136: FILE: drivers/gpu/drm/panel/panel-nec-nl8048hl11.c:85:
> + udelay(20);
> -:234: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!lcd"
> #234: FILE: drivers/gpu/drm/panel/panel-nec-nl8048hl11.c:183:
> + if (lcd == NULL)
> Nothing serious but please give them an extra round so we do
> not have extra patches flowing in to fix these trivial things.
> There is a few "line too long" that I personally would ignore.
> But warnings lige (lcd == NULL) => (!lcd) I would fix.
> And there was too much to fix while applying.
Forget this. I could use this existing little task to avoid some boring
Updated all checkpatch issues I considered relevant:
o (lcd == NULL) => (!lcd)
o <1 << X) => BIT(X)
And removed the __exit_p() annotation for a remove function to fix a
Build tested and applied to drm-misc-next.
More information about the dri-devel