[PATCH 1/2] gpu: ipu-v3: enable remaining 32-bit RGB V4L2 pixel formats

[Philipp Zabel]

Hi Marco,

On Thu, 2019-08-15 at 08:36 +0200, Marco Felsch wrote:
> Hi Philipp,
> 
> On 19-08-14 17:10, Philipp Zabel wrote:
> > Support is already implemented for the corresponding DRM formats,
> > just hook up the remaining V4L2 pixel formats.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> > ---
> >  drivers/gpu/ipu-v3/ipu-common.c | 16 ++++++++++------
> >  drivers/gpu/ipu-v3/ipu-cpmem.c  | 26 +++++++++++++++++++++++++-
> >  2 files changed, 35 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> > index 6386e2fe2ff7..ee2a025e54cf 100644
> > --- a/drivers/gpu/ipu-v3/ipu-common.c
> > +++ b/drivers/gpu/ipu-v3/ipu-common.c
> > @@ -113,13 +113,17 @@ enum ipu_color_space ipu_pixelformat_to_colorspace(u32 pixelformat)
> >  	case V4L2_PIX_FMT_NV16:
> >  	case V4L2_PIX_FMT_NV61:
> >  		return IPUV3_COLORSPACE_YUV;
> > -	case V4L2_PIX_FMT_XRGB32:
> > -	case V4L2_PIX_FMT_XBGR32:
> > -	case V4L2_PIX_FMT_RGB32:
> > -	case V4L2_PIX_FMT_BGR32:
> > -	case V4L2_PIX_FMT_RGB24:
> > -	case V4L2_PIX_FMT_BGR24:
> >  	case V4L2_PIX_FMT_RGB565:
> > +	case V4L2_PIX_FMT_BGR24:
> 
> Nitpick:
> Should we add '/* fall through */' comments? 

Not for this. -Wimplicit-fallthrough only requires annotation if there
are statements between two cases.

> Feel free to add my
> Reviewed-by: Marco Felsch <m.felsch at pengutronix.de>

Thanks!

regards
Philipp