[PATCH 1/2] video: omapfb2: Make standard and custom panel drivers mutually exclusive

Bartlomiej Zolnierkiewicz b.zolnierkie at samsung.com
Tue Aug 20 11:40:10 UTC 2019


On 8/19/19 5:17 PM, Sam Ravnborg wrote:
> Hi Bartlomiej

Hi Sam,

> On Mon, Aug 19, 2019 at 04:16:26PM +0200, Bartlomiej Zolnierkiewicz wrote:
>>
>> On 8/16/19 3:32 PM, Laurent Pinchart wrote:
>>> On Fri, Aug 16, 2019 at 04:20:46PM +0300, Tomi Valkeinen wrote:
>>>> On 16/08/2019 15:22, Laurent Pinchart wrote:
>>>>> Standard DRM panel drivers for several panels used by omapfb2 are now
>>>>> available. Their module name clashes with the modules from
>>>>> drivers/gpu/drm/omapdrm/displays/, part of the deprecated omapfb2 fbdev
>>>>
>>>> Shouldn't that path be drivers/video/fbdev/omap2/omapfb/displays?
>>>
>>> Absolutely :-) Could this be fixed when applying ? Otherwise I'll
>>> submit a v2.
>>>
>>>>> driver. As omapfb2 can only be compiled when the omapdrm driver is
>>>>> disabled, and the DRM panel drivers are useless in that case, make the
>>>>> omapfb2 panels depend on the standard DRM panels being disabled to fix
>>>>> the name clash.
>>>>>
>>>>> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>>>>> ---
>>>>>   drivers/video/fbdev/omap2/omapfb/displays/Kconfig | 5 +++++
>>>>>   1 file changed, 5 insertions(+)
>>>>
>>>> Cc'd Bartlomiej.
>>
>> Thanks Tomi.
>>
>>> Oops, sorry, forgot to do that :-S
>>>
>>>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
>>
>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> 
> I took the liberty to apply it already only with Tomi's r-b.

Fine with me, I don't want to block the merging process and I also
trust your judgment. :)

> Let me know if you want me to wait for your ack in the future.
> This was touching two sub-systems and it can
> in such cases sometimes be a challenge to get all acks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


More information about the dri-devel mailing list