[PATCH] drm/ingenic: Hardcode panel type to DPI

[Paul Cercueil]

Hi Laurent,


Le ven. 23 août 2019 à 23:23, Laurent Pinchart 
<laurent.pinchart at ideasonboard.com> a écrit :
> The ingenic driver supports DPI panels only at the moment, so hardcode
> their type to DPI instead of Unknown.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> Paul, as the driver has been merged in v5.3-rc1, this is a candidate 
> for
> a v5.3 fix. Keeping the connector type as unknown could cause a
> userspace dependency on it, preventing it from being changed later.

Makes sense.

Reviewed-by: Paul Cercueil <paul at crapouillou.net>


> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c 
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index ce1fae3a78a9..2e2ed653e9c6 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -675,10 +675,9 @@ static int ingenic_drm_probe(struct 
> platform_device *pdev)
>  		return ret;
>  	}
> 
> -	if (panel) {
> +	if (panel)
>  		bridge = devm_drm_panel_bridge_add(dev, panel,
> -						   DRM_MODE_CONNECTOR_Unknown);
> -	}
> +						   DRM_MODE_CONNECTOR_DPI);
> 
>  	priv->dma_hwdesc = dma_alloc_coherent(dev, 
> sizeof(*priv->dma_hwdesc),
>  					      &priv->dma_hwdesc_phys,
> --
> Regards,
> 
> Laurent Pinchart
>