[PATCH v2 15/50] drm/bridge: tfp410: Replace manual connector handling with bridge

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Aug 27 08:00:45 UTC 2019

Hi Tomi,

On Tue, Aug 27, 2019 at 10:43:15AM +0300, Tomi Valkeinen wrote:
> On 20/08/2019 04:16, Laurent Pinchart wrote:
> > Now that a driver is available for display connectors, replace the
> > manual connector handling code with usage of the DRM bridge API. The
> > tfp410 driver doesn't deal with the display connector directly anymore,
> > but still delegates drm_connector operations to the next bridge. This
> > brings us one step closer to having the tfp410 driver handling the
> > TFP410 only.
> The next step will drop those hpd related delayed works? They look 
> pretty ugly =).

Yesn all the connector-related code will disappear once users of the
TFP410 will switch to the new model.

> > +	dvi->bridge.type = DRM_MODE_CONNECTOR_DVID;
> This is not the connector type seen by userspace, is it? I have never 
> seen a board use TFP410 with a DVI connector...

The connector type reported to userspace comes from the HDMI connector
DT node, so dvi->bridge.type isn't very relevant there. I've set it to
DVID to match the hardware.


Laurent Pinchart

More information about the dri-devel mailing list