[RFC][PATCH] drm: kirin: Fix dsi probe/attach logic
Andrzej Hajda
a.hajda at samsung.com
Fri Aug 30 06:51:57 UTC 2019
On 29.08.2019 19:39, Rob Clark wrote:
> On Wed, Aug 28, 2019 at 11:06 PM John Stultz <john.stultz at linaro.org> wrote:
>> Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI
>> host at probe time") landed in -next the HiKey board would fail
>> to boot, looping:
> No, please revert 83f35bc3a852.. that is going in the *complete* wrong
> direction. We actually should be moving panels to not require dsi
> host until attach time, similar to how bridges work, not the other way
> around.
Devices of panels and bridges controlled via DSI will not appear at all
if DSI host is not created.
So this is the only direction!!!
>
> The problem is that, when dealing with bootloader enabled display, we
> need to be really careful not to touch the hardware until the display
> driver knows the bridge/panel is present. If the bridge/panel probes
> after the display driver, we could end up killing scanout
> (efifb/simplefb).. if the bridge/panel is missing some dependency and
> never probes, it is rather unpleasant to be stuck trying to debug what
> went wrong with no display.
It has nothing to do with touching hardware, you can always (I hope)
postpone it till all components are present.
But it is just requirement of device/driver model in Linux Kernel.
>
> Sorry I didn't notice that adv7511 patch before it landed, but the
> right thing to do now is to revert it.
The 1st version of the patch was posted at the end of April and final
version was queued 1st July, so it was quite long time for discussions
and tests.
Reverting it now seems quite late, especially if the patch does right
thing and there is already proper fix for one encoder (kirin), moreover
revert will break another platforms.
Of course it seems you have different opinion what is the right thing in
this case, so if you convince us that your approach is better one can
revert the patch.
Regards
Andrzej
>
> BR,
> -R
>
>> adv7511 2-0039: failed to find dsi host
>>
>> messages over and over. Andrzej Hajda suggested this is due to a
>> circular dependency issue, and that the adv7511 change is
>> correcting the improper order used earlier.
>>
>> Unfortunately this means the DSI drivers that use adv7511 need
>> to also need to be updated to use the proper ordering to
>> continue to work.
>>
>> This patch tries to reorder the initialization to register the
>> dsi_host first, and then call component_add via dsi_host_attach,
>> instead of doing that at probe time.
>>
>> This seems to resolve the issue with the HiKey board.
>>
>> Cc: Andrzej Hajda <a.hajda at samsung.com>
>> Cc: Matt Redfearn <matt.redfearn at thinci.com>
>> Cc: Xinliang Liu <z.liuxinliang at hisilicon.com>
>> Cc: Rongrong Zou <zourongrong at gmail.com>
>> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
>> Cc: Neil Armstrong <narmstrong at baylibre.com>
>> Cc: Jonas Karlman <jonas at kwiboo.se>
>> Cc: Jernej Skrabec <jernej.skrabec at siol.net>
>> Cc: Thierry Reding <thierry.reding at gmail.com>
>> Cc: David Airlie <airlied at linux.ie>,
>> Cc: Sean Paul <seanpaul at chromium.org>
>> Cc: Sam Ravnborg <sam at ravnborg.org>
>> Cc: "dri-devel at lists.freedesktop.org" <dri-devel at lists.freedesktop.org>
>> Fixes: 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI host at probe time")
>> Signed-off-by: John Stultz <john.stultz at linaro.org>
>> ---
>> Note: I'm really not super familiar with the DSI code here,
>> and am mostly just trying to refactor the existing code in a
>> similar fashion to the suggested dw-mipi-dsi-rockchip.c
>> implementation. Careful review would be greatly appreciated!
>>
>> Also there is an outstanding regression on the db410c since it
>> similarly uses the adv7511 and probably needs a similar rework.
>> ---
>> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 111 ++++++++++---------
>> 1 file changed, 56 insertions(+), 55 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
>> index 5bf8138941de..696cee1a1219 100644
>> --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
>> +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
>> @@ -79,6 +79,7 @@ struct dsi_hw_ctx {
>> };
>>
>> struct dw_dsi {
>> + struct device *dev;
>> struct drm_encoder encoder;
>> struct drm_bridge *bridge;
>> struct mipi_dsi_host host;
>> @@ -724,51 +725,6 @@ static int dw_drm_encoder_init(struct device *dev,
>> return 0;
>> }
>>
>> -static int dsi_host_attach(struct mipi_dsi_host *host,
>> - struct mipi_dsi_device *mdsi)
>> -{
>> - struct dw_dsi *dsi = host_to_dsi(host);
>> -
>> - if (mdsi->lanes < 1 || mdsi->lanes > 4) {
>> - DRM_ERROR("dsi device params invalid\n");
>> - return -EINVAL;
>> - }
>> -
>> - dsi->lanes = mdsi->lanes;
>> - dsi->format = mdsi->format;
>> - dsi->mode_flags = mdsi->mode_flags;
>> -
>> - return 0;
>> -}
>> -
>> -static int dsi_host_detach(struct mipi_dsi_host *host,
>> - struct mipi_dsi_device *mdsi)
>> -{
>> - /* do nothing */
>> - return 0;
>> -}
>> -
>> -static const struct mipi_dsi_host_ops dsi_host_ops = {
>> - .attach = dsi_host_attach,
>> - .detach = dsi_host_detach,
>> -};
>> -
>> -static int dsi_host_init(struct device *dev, struct dw_dsi *dsi)
>> -{
>> - struct mipi_dsi_host *host = &dsi->host;
>> - int ret;
>> -
>> - host->dev = dev;
>> - host->ops = &dsi_host_ops;
>> - ret = mipi_dsi_host_register(host);
>> - if (ret) {
>> - DRM_ERROR("failed to register dsi host\n");
>> - return ret;
>> - }
>> -
>> - return 0;
>> -}
>> -
>> static int dsi_bridge_init(struct drm_device *dev, struct dw_dsi *dsi)
>> {
>> struct drm_encoder *encoder = &dsi->encoder;
>> @@ -796,10 +752,6 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>> if (ret)
>> return ret;
>>
>> - ret = dsi_host_init(dev, dsi);
>> - if (ret)
>> - return ret;
>> -
>> ret = dsi_bridge_init(drm_dev, dsi);
>> if (ret)
>> return ret;
>> @@ -817,13 +769,22 @@ static const struct component_ops dsi_ops = {
>> .unbind = dsi_unbind,
>> };
>>
>> -static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
>> +static int dsi_host_attach(struct mipi_dsi_host *host,
>> + struct mipi_dsi_device *mdsi)
>> {
>> - struct dsi_hw_ctx *ctx = dsi->ctx;
>> - struct device_node *np = pdev->dev.of_node;
>> - struct resource *res;
>> + struct dw_dsi *dsi = host_to_dsi(host);
>> + struct device_node *np = dsi->dev->of_node;
>> int ret;
>>
>> + if (mdsi->lanes < 1 || mdsi->lanes > 4) {
>> + DRM_ERROR("dsi device params invalid\n");
>> + return -EINVAL;
>> + }
>> +
>> + dsi->lanes = mdsi->lanes;
>> + dsi->format = mdsi->format;
>> + dsi->mode_flags = mdsi->mode_flags;
>> +
>> /*
>> * Get the endpoint node. In our case, dsi has one output port1
>> * to which the external HDMI bridge is connected.
>> @@ -832,6 +793,42 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
>> if (ret)
>> return ret;
>>
>> + return component_add(dsi->dev, &dsi_ops);
>> +}
>> +
>> +static int dsi_host_detach(struct mipi_dsi_host *host,
>> + struct mipi_dsi_device *mdsi)
>> +{
>> + /* do nothing */
>> + return 0;
>> +}
>> +
>> +static const struct mipi_dsi_host_ops dsi_host_ops = {
>> + .attach = dsi_host_attach,
>> + .detach = dsi_host_detach,
>> +};
>> +
>> +static int dsi_host_init(struct device *dev, struct dw_dsi *dsi)
>> +{
>> + struct mipi_dsi_host *host = &dsi->host;
>> + int ret;
>> +
>> + host->dev = dev;
>> + host->ops = &dsi_host_ops;
>> + ret = mipi_dsi_host_register(host);
>> + if (ret) {
>> + DRM_ERROR("failed to register dsi host\n");
>> + return ret;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
>> +{
>> + struct dsi_hw_ctx *ctx = dsi->ctx;
>> + struct resource *res;
>> +
>> ctx->pclk = devm_clk_get(&pdev->dev, "pclk");
>> if (IS_ERR(ctx->pclk)) {
>> DRM_ERROR("failed to get pclk clock\n");
>> @@ -862,15 +859,19 @@ static int dsi_probe(struct platform_device *pdev)
>> }
>> dsi = &data->dsi;
>> ctx = &data->ctx;
>> + dsi->dev = &pdev->dev;
>> dsi->ctx = ctx;
>>
>> ret = dsi_parse_dt(pdev, dsi);
>> if (ret)
>> return ret;
>>
>> - platform_set_drvdata(pdev, data);
>> + ret = dsi_host_init(&pdev->dev, dsi);
>> + if (ret)
>> + return ret;
>>
>> - return component_add(&pdev->dev, &dsi_ops);
>> + platform_set_drvdata(pdev, data);
>> + return 0;
>> }
>>
>> static int dsi_remove(struct platform_device *pdev)
>> --
>> 2.17.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
More information about the dri-devel
mailing list