[PATCH 2/5] udmabuf: allow userspace to set map attributes

[Gurchetan Singh]

On Thu, Nov 28, 2019 at 3:48 AM Gerd Hoffmann <kraxel at redhat.com> wrote:
>
>   Hi,
>
> > diff --git a/include/uapi/linux/udmabuf.h b/include/uapi/linux/udmabuf.h
> > index 46b6532ed855..f90831f2bb0d 100644
> > --- a/include/uapi/linux/udmabuf.h
> > +++ b/include/uapi/linux/udmabuf.h
> > @@ -6,6 +6,8 @@
> >  #include <linux/ioctl.h>
> >
> >  #define UDMABUF_FLAGS_CLOEXEC        0x01
> > +#define UDMABUF_FLAGS_WC     0x02
> > +#define UDMABUF_FLAGS_NONCACHED 0x04
> >
> >  struct udmabuf_create {
> >       __u32 memfd;
>
> This is a uapi change and should go to a separate patch,
> clearly flagging that in $subject.
>
> (new policy by airlied for the drm tree).

The new policy requires a non-toy userspace[1], which may take a
while.  Removed the UAPI changes in the latest patch series.

[1] https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-uapi.html#open-source-userspace-requirements

>
> Otherwise the series looks good to me.
>
> cheers,
>   Gerd
>