[PATCH 02/12] drm/pci: Hide legacy PCI functions from non-legacy code

Emil Velikov emil.l.velikov at gmail.com
Tue Dec 3 11:06:43 UTC 2019


Hi Thomas,

On Tue, 3 Dec 2019 at 10:04, Thomas Zimmermann <tzimmermann at suse.de> wrote:
>
> Declarations of drm_legacy_pci_{init,exit}() are being moved to
> drm_legacy.h. CONFIG_DRM_LEGACY protects the implementation.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>  drivers/gpu/drm/drm_pci.c |  4 ++++
>  include/drm/drm_legacy.h  | 29 ++++++++++++++++++++++++++++-
>  include/drm/drm_pci.h     | 15 ---------------
>  3 files changed, 32 insertions(+), 16 deletions(-)
>
How about we make this patch 01/12, this way we can avoid the current
case of - add code only to be moved in next patch.

As always - couple of ideas for follow-up cleanups.
 - drm_irq_by_busid() is legacy codebase (see the DRIVER_LEGACY check
at the top). How about we give it a _legacy_ name?
 - WE HAVE A FEW driver_features


More information about the dri-devel mailing list