[PATCH] drm/tilcdc: Switch to using GPIO descriptors

Sam Ravnborg sam at ravnborg.org
Wed Dec 4 14:30:14 UTC 2019


Hi Jyri.

On Tue, Dec 03, 2019 at 08:29:45PM +0200, Jyri Sarha wrote:
> On 03/12/2019 15:09, Linus Walleij wrote:
> > The TI LCDC picks a GPIO line from the device tree to use
> > for DPMS power on/off. We can switch this to use a GPIO
> > descriptor pretty easily. Make sure to request the GPIO
> > "as is" so that the DPMS state that we start (boot) in is
> > preserved.
> > 
> 
> Hmmm, I have been considering ditching this driver all together since no
> mainline platform has ever used it. Also, if anybody ever wants to
> connect tfp410 to tilcdc, he should use drm/bridge/ti-tfp410.c instead.
> 
> But since the patch is there, maybe I should pick it up, and remove the
> bundled driver later a bit later.

IMO much better to just get rid of it now - as there is anyway no users.
No reason to patch code that is essential dead.
You just postpone the task for no gain.

	Sam


More information about the dri-devel mailing list