[PATCH] drm/mgag200: Debug-print unique revisions id on G200 SE

Gerd Hoffmann kraxel at redhat.com
Thu Dec 5 08:03:02 UTC 2019


On Wed, Dec 04, 2019 at 02:34:35PM +0100, Thomas Zimmermann wrote:
> The behavior of MGA G200 SE depends on the rev id. Print the id when
> debugging is enabled.

That is the one where some need a workaround, right?

> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
>  drivers/gpu/drm/mgag200/mgag200_main.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c
> index e1bc5b0aa774..aeb7c10ded0d 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_main.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_main.c
> @@ -118,8 +118,11 @@ static int mgag200_device_init(struct drm_device *dev,
>  		return -ENOMEM;
>  
>  	/* stash G200 SE model number for later use */
> -	if (IS_G200_SE(mdev))
> +	if (IS_G200_SE(mdev)) {
>  		mdev->unique_rev_id = RREG32(0x1e24);
> +		DRM_DEBUG("G200 SE unique revision id is 0x%x\n",
> +			  mdev->unique_rev_id);

Maybe use DRM_INFO here?  Temporarily for a few kernel revisions, until
things are settled?

(just a suggestion, your choice).

Acked-by: Gerd Hoffmann <kraxel at redhat.com>

cheers,
  Gerd



More information about the dri-devel mailing list