[PATCH v2 3/3] drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe

Jyri Sarha jsarha at ti.com
Mon Dec 9 14:42:16 UTC 2019


Add WARN() to the beginnig of tilcdc-panel probe. The obsolete
tilcdc-panel driver should not be used anymore, since tilcdc is fully
capable of using generic drm panels like panel-simple and panel-common
binding.

Signed-off-by: Jyri Sarha <jsarha at ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 5584e656b857..cf8e2462a524 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)
 	struct pinctrl *pinctrl;
 	int ret;
 
+	/*
+	 * The obsolete tilcdc-panel driver should not be used
+         * anymore, since tilcdc is fully capable of using generic drm
+         * panels like panel-simple and panel-common binding.
+	 */
+
+	WARN(true,
+	     "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",
+	     dev_name(&pdev->dev));
+
 	/* bail out early if no DT data: */
 	if (!node) {
 		dev_err(&pdev->dev, "device-tree data is missing\n");
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki



More information about the dri-devel mailing list