[PATCHv4 12/36] drm/komeda: Move pitches comparison to komeda_fb_create
Andrzej Pietrasiewicz
andrzej.p at collabora.com
Fri Dec 13 15:58:43 UTC 2019
For AFBC case num_planes equals 1 so the check will not affect it.
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p at collabora.com>
---
.../drm/arm/display/komeda/komeda_framebuffer.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
index 157b73005ef8..4fa01b2e3f1c 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
@@ -133,13 +133,6 @@ komeda_fb_none_afbc_size_check(struct komeda_dev *mdev,
}
}
- if (info->num_planes == 3) {
- if (fb->pitches[1] != fb->pitches[2]) {
- DRM_DEBUG_KMS("The pitch[1] and [2] are not same\n");
- return -EINVAL;
- }
- }
-
return 0;
}
@@ -189,6 +182,13 @@ komeda_fb_create(struct drm_device *dev, struct drm_file *file,
if (ret < 0)
goto err_cleanup;
+ if (info->num_planes == 3)
+ if (kfb->base.pitches[1] != kfb->base.pitches[2]) {
+ DRM_DEBUG_KMS("The pitch[1] and [2] are not same\n");
+ ret = -EINVAL;
+ goto err_cleanup;
+ }
+
ret = drm_framebuffer_init(dev, &kfb->base, &komeda_fb_funcs);
if (ret < 0) {
DRM_DEBUG_KMS("failed to initialize fb\n");
--
2.17.1
More information about the dri-devel
mailing list