[PATCH] drm/panfrost: Prefix interrupt handlers' names

Alyssa Rosenzweig alyssa.rosenzweig at collabora.com
Fri Dec 13 15:51:45 UTC 2019


> (Feedback for kernel patches on the same day, am I dreaming??)

That's panfrost!

> > Agreed, while the current implementation may be confusing it is at least 
> > self-consistent. TBH it would probably be sufficient to save the bother 
> > of allocating strings and just settle on "panfrost-{gpu,job,mmu}", since 
> > upstream users are unlikely to ever come across a system with more than 
> > one Mali in it ;)
> > 
> > And FWIW note that "GPU" really is the specific hardware name of that 
> > IRQ output; it's not just a generic fill-in for "the one that isn't the 
> > Job or MMU IRQ".
> > 
> 
> Yeah, that makese sense. So how about we go for "panfrost-{job,mmu}"
> and leave the "gpu" one?
> 
> Or "panfrost-{gpu,job,mmu}" for consistency?

I would prefer "panfrost-{gpu,job,mmu}" for consistency, I think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20191213/3d427cec/attachment-0001.sig>


More information about the dri-devel mailing list