[PATCH] drm: panel-orientation-quirks: Add quirk for Teclast X89 tablet
Hans de Goede
hdegoede at redhat.com
Sun Dec 15 18:42:46 UTC 2019
Hi,
On 11-12-2019 18:38, Hans de Goede wrote:
> Hi,
>
> I know these kinda patches are sorta trivial, still I prefer to get an
> Acked-by before pushing this to drm-misc-next. Can someone review this please?
>
> Alternative I guess we could agree that pushing patches which just add a dmi
> quirk to drm_panel_orientation_quirks.c is ok when the patch has sat on the
> list without any response for a week ?
Nevermind, for devices with an upside-down panel the info is in the VBT and
we should use that instead of doing a quirk, self-nack.
Regards,
Hans
> On 02-12-2019 11:50, Hans de Goede wrote:
>> The Teclast X89 uses an upside-down mounted eDP panel, add a
>> panel-orientation quirk for this.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>> drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index ffd95bfeaa94..9f2d12f28a73 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -108,6 +108,13 @@ static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
>> .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>> };
>> +static const struct drm_dmi_panel_orientation_data teclast_x89 = {
>> + .width = 1536,
>> + .height = 2048,
>> + .bios_dates = (const char * const []){ "12/19/2014", NULL },
>> + .orientation = DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP,
>> +};
>> +
>> static const struct dmi_system_id orientation_data[] = {
>> { /* Acer One 10 (S1003) */
>> .matches = {
>> @@ -205,6 +212,12 @@ static const struct dmi_system_id orientation_data[] = {
>> DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
>> },
>> .driver_data = (void *)&lcd1200x1920_rightside_up,
>> + }, { /* Teclast X89 (tPAD is too generic, also match on bios date) */
>> + .matches = {
>> + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
>> + DMI_EXACT_MATCH(DMI_BOARD_NAME, "tPAD"),
>> + },
>> + .driver_data = (void *)&teclast_x89,
>> }, { /* VIOS LTH17 */
>> .matches = {
>> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
>>
More information about the dri-devel
mailing list