[PATCH v2] backlight: pwm_bl: Switch to full GPIO descriptor

Lee Jones lee.jones at linaro.org
Mon Dec 16 16:16:20 UTC 2019


On Fri, 13 Dec 2019, Linus Walleij wrote:

> The PWM backlight still supports passing a enable GPIO line as
> platform data using the legacy <linux/gpio.h> API.
> 
> It turns out that ever board using this mechanism except one
> is pass .enable_gpio = -1. So we drop all these cargo-culted -1's
> from all instances of this platform data in the kernel.
> 
> The remaning board, Palm TC, is converted to pass a machine
> descriptior table with the "enable" GPIO instead, and delete the
> platform data entry for enable_gpio and the code handling it
> and things should work smoothly with the new API.
> 
> Cc: Krzysztof Kozlowski <krzk at kernel.org>
> Cc: Robert Jarzmik <robert.jarzmik at free.fr>
> Cc: Guan Xuetao <gxt at pku.edu.cn>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski at baylibre.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>

Happy to handle this, but it requires more Acks.

> ---
> ChangeLog v1->v2:
> - Located a missing removal of .enable_gpio in the Palm TC
>   board file, pointed out by Daniel.
> - Grepped to ascertain there is not a single instance of
>   the string "enable_gpio" in the affected board files.
> ---
>  arch/arm/mach-pxa/cm-x300.c               |  1 -
>  arch/arm/mach-pxa/colibri-pxa270-income.c |  1 -
>  arch/arm/mach-pxa/ezx.c                   |  1 -
>  arch/arm/mach-pxa/hx4700.c                |  1 -
>  arch/arm/mach-pxa/lpd270.c                |  1 -
>  arch/arm/mach-pxa/magician.c              |  1 -
>  arch/arm/mach-pxa/mainstone.c             |  1 -
>  arch/arm/mach-pxa/mioa701.c               |  1 -
>  arch/arm/mach-pxa/palm27x.c               |  1 -
>  arch/arm/mach-pxa/palmtc.c                | 11 ++++++++++-
>  arch/arm/mach-pxa/palmte2.c               |  1 -
>  arch/arm/mach-pxa/pcm990-baseboard.c      |  1 -
>  arch/arm/mach-pxa/tavorevb.c              |  2 --
>  arch/arm/mach-pxa/viper.c                 |  1 -
>  arch/arm/mach-pxa/z2.c                    |  2 --
>  arch/arm/mach-pxa/zylonite.c              |  1 -
>  arch/arm/mach-s3c24xx/mach-h1940.c        |  1 -
>  arch/arm/mach-s3c24xx/mach-rx1950.c       |  1 -
>  arch/arm/mach-s3c64xx/dev-backlight.c     |  3 ---
>  arch/arm/mach-s3c64xx/mach-crag6410.c     |  1 -
>  arch/arm/mach-s3c64xx/mach-hmt.c          |  1 -
>  arch/arm/mach-s3c64xx/mach-smartq.c       |  1 -
>  arch/arm/mach-s3c64xx/mach-smdk6410.c     |  2 +-
>  arch/unicore32/kernel/puv3-nb0916.c       |  1 -
>  drivers/video/backlight/pwm_bl.c          | 19 -------------------
>  include/linux/pwm_backlight.h             |  2 --
>  26 files changed, 11 insertions(+), 49 deletions(-)

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


More information about the dri-devel mailing list