[PATCH v3 26/50] drm/omap: hdmi4: Rework EDID read to isolate data read

Tomi Valkeinen tomi.valkeinen at ti.com
Tue Dec 17 12:25:24 UTC 2019


On 11/12/2019 00:57, Laurent Pinchart wrote:
> In preparation of adding DRM bridge support to the hdmi4 encoder code,
> rework the EDID read to isolate data read.
> 
> The hdmi_read_edid() function is the main entry point. It performs all
> initialisation steps required prior to reading the EDID (such as
> ensuring the device is powered on), as well as corresponding cleanup
> steps afterwards. EDID read itself is handled by hdmi_read_edid_data()
> that calls the hdmi4_core_ddc_read() function to read individual blocks.
> 
> This new code architecture will allow reusing hdmi_read_edid() and
> hdmi4_core_ddc_read() for the drm_bridge EDID read implementation, while
> swapping out hdmi_read_edid_data() for the DRM drm_do_get_edid()
> function.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> Changes since v2:
> 
> - Expand commit message
> ---
>   drivers/gpu/drm/omapdrm/dss/hdmi4.c      | 94 +++++++++++++++---------
>   drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 59 +++------------
>   drivers/gpu/drm/omapdrm/dss/hdmi4_core.h |  4 +-
>   3 files changed, 73 insertions(+), 84 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


More information about the dri-devel mailing list