[PATCH v3 11/50] drm/bridge: Add bridge driver for display connectors

[Tomi Valkeinen]

On 18/12/2019 03:45, Laurent Pinchart wrote:

>>> +	dev_info(&pdev->dev,
>>> +		 "Found %s display connector '%s' %s DDC bus and %s HPD GPIO (ops 0x%x)\n",
>>> +		 drm_get_connector_type_name(conn->bridge.type),
>>> +		 conn->label ? conn->label : "<unlabelled>",
>>> +		 conn->bridge.ddc ? "with" : "without",
>>> +		 conn->hpd_gpio ? "with" : "without",
>>> +		 conn->bridge.ops);
>>
>> On AM5 EVM, we have HDMI output with DDC and HPD, but I get a kernel print:
>>
>> display-connector connector: Found HDMI-A display connector 'hdmi' without DDC bus and without HPD
>> GPIO (ops 0x0)
>>
>> I think that print may be quite confusing for someone who doesn't know the details of the drivers
>> involved.
> 
> I agree, but the information could be useful for developers. Do you
> think it should be dropped ? Or do you have an alternative wording to
> propose ?

I would just go with dev_dbg. I personally don't like to use dev_info unless it's really something a 
normal user needs to see. Otherwise it's just spam for most of the people. If everything is fine, I 
think the driver should be quiet.

Did we discuss this already earlier? =)

That said, even as a dev_dbg it's somewhat confusing. But I can't come up with alternate working... 
Somehow it should indicate that this piece of the display pipeline doesn't handle DDC/HPD, without 
implying that there are no such features.

"unassigned DDC"? I don't know... I'm fine with the print as dev_dbg.

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki