[PATCH] drm/vmwgfx: remove unnecessary assertion in vmw_resource_alloc_id

Aditya Pakki pakki001 at umn.edu
Wed Dec 18 18:51:09 UTC 2019


Every caller of vmw_resource_alloc_id checks if id is not -1. The
assertion in the said function is thus redundant and can be removed.
The patch removes the check.

Signed-off-by: Aditya Pakki <pakki001 at umn.edu>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
index c8441030637a..50c8eb8012fd 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
@@ -183,8 +183,6 @@ int vmw_resource_alloc_id(struct vmw_resource *res)
 	int ret;
 	struct idr *idr = &dev_priv->res_idr[res->func->res_type];
 
-	BUG_ON(res->id != -1);
-
 	idr_preload(GFP_KERNEL);
 	spin_lock(&dev_priv->resource_lock);
 
-- 
2.20.1



More information about the dri-devel mailing list