BAD -- Patch "drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>" has been added to the 5.4-stable tree

[John Donnelly]

Hi 

I am having difficulties with this patch on : 5.4.2  variant ;  The system is not booting with these patches applied. 

I had verified a prototype of the patch on 5.4.0-rc8 ;    

 I am currently debugging it ,  but I will be OoO until 1/6/2020 after today .










> On Dec 19, 2019, at 5:37 AM, gregkh at linuxfoundation.org wrote:
> 
> 
> This is a note to let you know that I've just added the patch titled
> 
>    drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
> 
> to the 5.4-stable tree which can be found at:
>    https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-3Dlinux_kernel_git_stable_stable-2Dqueue.git-3Ba-3Dsummary&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo&s=mqHE1ETbyuc9Qg_WHNUzDRBGo073QFCYwTAxpxXEQJU&e= 
> 
> The filename of the patch is:
>     drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
> and it can be found in the queue-5.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable at vger.kernel.org> know about it.
> 
> 
> From 4adf0b49eea926a55fd956ef7d86750f771435ff Mon Sep 17 00:00:00 2001
> From: Thomas Zimmermann <tzimmermann at suse.de>
> Date: Fri, 6 Dec 2019 09:19:01 +0100
> Subject: drm/mgag200: Flag all G200 SE A machines as broken wrt <startadd>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> From: Thomas Zimmermann <tzimmermann at suse.de>
> 
> commit 4adf0b49eea926a55fd956ef7d86750f771435ff upstream.
> 
> Several MGA G200 SE machines don't respect the value of the startadd
> register field. After more feedback on affected machines, neither PCI
> subvendor ID nor the internal ID seem to hint towards the bug. All
> affected machines have a PCI ID of 0x0522 (i.e., G200 SE A). It was
> decided to flag all G200 SE A machines as broken.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Acked-by: Gerd Hoffmann <kraxel at redhat.com>
> Fixes: 1591fadf857c ("drm/mgag200: Add workaround for HW that does not support 'startadd'")
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: John Donnelly <john.p.donnelly at oracle.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Gerd Hoffmann <kraxel at redhat.com>
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: "Y.C. Chen" <yc_chen at aspeedtech.com>
> Cc: Neil Armstrong <narmstrong at baylibre.com>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Cc: "José Roberto de Souza" <jose.souza at intel.com>
> Cc: Andrzej Pietrasiewicz <andrzej.p at collabora.com>
> Cc: dri-devel at lists.freedesktop.org
> Cc: <stable at vger.kernel.org> # v5.3+
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Allison Randal <allison at lohutok.net>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Noralf Trønnes" <noralf at tronnes.org>
> Link: https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.freedesktop.org_patch_msgid_20191206081901.9938-2D1-2Dtzimmermann-40suse.de&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=t2fPg9D87F7D8jm0_3CG9yoiIKdRg4qc_thBw4bzMhc&m=Nb5EnzCYEqUCU43_FPM930DrN6A-OrVBoIvQhl3A6xo&s=hkr0WOmd31sveBOYMZnLk8Sb2ujD-JxnYwjeSLBw9cA&e= 
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> 
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c |    3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -30,9 +30,8 @@ module_param_named(modeset, mgag200_mode
> static struct drm_driver driver;
> 
> static const struct pci_device_id pciidlist[] = {
> -	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_VENDOR_ID_SUN, 0x4852, 0, 0,
> +	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> 		G200_SE_A | MGAG200_FLAG_HW_BUG_NO_STARTADD},
> -	{ PCI_VENDOR_ID_MATROX, 0x522, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_A },
> 	{ PCI_VENDOR_ID_MATROX, 0x524, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_SE_B },
> 	{ PCI_VENDOR_ID_MATROX, 0x530, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_EV },
> 	{ PCI_VENDOR_ID_MATROX, 0x532, PCI_ANY_ID, PCI_ANY_ID, 0, 0, G200_WB },
> 
> 
> Patches currently in stable-queue which might be from tzimmermann at suse.de are
> 
> queue-5.4/drm-mgag200-flag-all-g200-se-a-machines-as-broken-wrt-startadd.patch
> queue-5.4/drm-mgag200-store-flags-from-pci-driver-data-in-device-structure.patch
> queue-5.4/drm-mgag200-add-workaround-for-hw-that-does-not-support-startadd.patch
> queue-5.4/drm-mgag200-extract-device-type-from-flags.patch