[PATCH 02/10] drm/etnaviv: mmuv2: don't map zero page

[Christian Gmeiner]

Am Mi., 19. Dez. 2018 um 15:45 Uhr schrieb Lucas Stach <l.stach at pengutronix.de>:
>
> Keep the page at address 0 as faulting to catch any potential state
> setup issues early.
>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

I like this idea.. but I am unsure about Guido's GC7000 problem.

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> index f1c88d8ad5ba..f794e04be9e6 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> @@ -320,8 +320,8 @@ etnaviv_iommuv2_domain_alloc(struct etnaviv_gpu *gpu)
>         domain = &etnaviv_domain->base;
>
>         domain->dev = gpu->dev;
> -       domain->base = 0;
> -       domain->size = (u64)SZ_1G * 4;
> +       domain->base = SZ_4K;
> +       domain->size = (u64)SZ_1G * 4 - SZ_4K;
>         domain->ops = &etnaviv_iommuv2_ops;
>
>         ret = etnaviv_iommuv2_init(etnaviv_domain);
> --
> 2.19.1
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info