[PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

Strasser, Kevin kevin.strasser at intel.com
Mon Feb 4 22:16:29 UTC 2019


Ville Syrjälä wrote:
> Kevin Strasser wrote:
> > Ville Syrjälä wrote:
> > > is_hdr_plane() is around now, please use it.
> >
> > I don't think I can use icl_is_hdr_plane here without some refactoring. It
> > requires the plane->base to be initialized through drm_universal_plane_init,
> > which depends on formats/num_formats pointers to be already set.
>
> Hmm. We should probably just convert it into
>
> icl_is_hdr_plane(struct drm_i915_private *dev_priv,
>                  enum plane_id plane_id);

That sounds reasonable, I'll include this in v3.

Thanks,
Kevin


More information about the dri-devel mailing list