[PATCH 2/2] drm/lima: driver for ARM Mali4xx GPUs

Rob Herring robh at kernel.org
Wed Feb 13 01:46:27 UTC 2019


On Tue, Feb 12, 2019 at 6:56 PM Qiang Yu <yuq825 at gmail.com> wrote:
>
> On Tue, Feb 12, 2019 at 11:47 PM Rob Herring <robh at kernel.org> wrote:
> >
> > On Wed, Feb 6, 2019 at 7:16 AM Qiang Yu <yuq825 at gmail.com> wrote:
> > >
> > > From: Lima Project Developers <lima at lists.freedesktop.org>
> >
> > This should be a person (you).
> >
> > > Signed-off-by: Andreas Baierl <ichgeh at imkreisrum.de>
> > > Signed-off-by: Erico Nunes <nunes.erico at gmail.com>
> > > Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> > > Signed-off-by: Marek Vasut <marex at denx.de>
> > > Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
> > > Signed-off-by: Qiang Yu <yuq825 at gmail.com>
> >
> > Being the submitter, your S-o-b should be last.
> >
> > > Signed-off-by: Simon Shields <simon at lineageos.org>
> > > Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>
> > > ---

> > > +
> > > +unsigned long lima_timeout_to_jiffies(u64 timeout_ns)
> >
> > Create a common helper instead of copy-n-pasting this from other
> > drivers (etnaviv).
> There's one drm_timeout_abs_to_jiffies but not exported.

Then let's export it. We don't work around kernel APIs or lack of. We fix them.


Rob


More information about the dri-devel mailing list