[PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol
Bartlomiej Zolnierkiewicz
b.zolnierkie at samsung.com
Wed Feb 13 16:12:42 UTC 2019
On 02/13/2019 04:19 PM, Daniel Vetter wrote:
> On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via
> dri-devel <dri-devel at lists.freedesktop.org> wrote:
>>
>>
>> On 02/12/2019 09:42 AM, Lee Jones wrote:
>>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote:
>>>
>>>>
>>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:
>>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote:
>>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE
>>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job.
>>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option
>>>>>> and converts LCD_CLASS_DEVICE into a menu.
>>>>>>
>>>>>> Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
>>>>>
>>>>> A cover letter with the v1 -> v2 changelog would be nice... but
>>>>> nevertheless:
>>>>> Acked-by: Daniel Thompson <daniel.thompson at linaro.org>
>>>>
>>>> Also:
>>>>
>>>> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
>>>>
>>>> Lee, will you pick this up or do you want me to do it?
>>>
>>> You can take them if you want. I will require a pull-request from an
>>> independent immutable branch though please.
>>
>> OK, immutable branch will also allow other trees (drm) to sync with
>> these changes if desired.
>>
>> I will do it for v5.2 if you are fine with it (too late for v5.1
>> IMHO and I also won't have time too fix any potential issues next
>> week).
>
> Topic branch for these 2 simple patches seems like serious overkill.
> Especially for backlight stuff, which doesn't move fast. Anyway, up to
This depends on the development stage we are in [*]. Right now things
are calm so there is low probability of conflicts and we might just
merge these patches without topic branch.
[*] In case of fbdev/Kconfig FB_CLPS711X config option was modified
in v4.20 and both FB_IMX and FB_MX3 config options still need to be
converted to support COMPILE_TEST so at least in theory there is
a potential for conflicts with fbdev if merged for 5.2.
> you, ack for all the drm patches to go through whatever tree you
> people can agree on. Would be good to get it into 5.1 still though,
> just to avoid too many conflicts.
Well, if so I'm also fine with this going in 5.1 w/o topic branch.
Lee, do you want to merge this directly into backlight tree (you
have now both fbdev and drm acks)?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
More information about the dri-devel
mailing list