Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

[Jani Nikula]

On Wed, 13 Feb 2019, Thierry Reding <thierry.reding at gmail.com> wrote:
> On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamaría Rogado wrote:
>> Sorry previous one wasn't signed off by.
>
> And now you've got this comment in the commit message that's going to
> confuse people looking at the log.
>
> It's usually to put this kind of comment below the --- line...
>
>> The (void *) casting in the driver_data variable assignment is superfluous.
>> Spotted by Jani Nikula.

Please either make that

Suggested-by: Jani Nikula <jani.nikula at intel.com>

or leave out completely.


>> 
>> Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
>> ---
>
> ... right here.
>
>>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> Otherwise, looks good to me:
>
> Acked-by: Thierry Reding <treding at nvidia.com>

With Thierry's suggestion fixed,

Reviewed-by: Jani Nikula <jani.nikula at intel.com>



-- 
Jani Nikula, Intel Open Source Graphics Center