[PATCH 2/2] drm/tilcdc: Remove unnecessary struct tilcdc_panel_info members

[Tomi Valkeinen]

On 15/02/2019 10:13, Jyri Sarha wrote:
> Most of the struct tilcdc_panel_info data members, that are also
> exposed in dts binding, are essentially display IP register bits that
> should not need customization per connected display basis. This patch
> removes them, both from the binding and the struct. The removed data
> members have sane static values and there should be no need to expose
> them in the device tree, certainly not in the panel node.
> 
> The removed data members are: ac_bias, ac_bias_intrpt, dma_burst_sz,
> bpp, fdd, sync-ctrl, tft_alt_mode, and raster_order. All of those are
> removed from the driver implementation and from bundled tilcdc panel
> binding. The driver now configures the tilcdc with the sane static
> values, instead of whatever the driver finds from the struct
> tilcdc_panel_info.
> 
> The patch does does not cause any functional change to any platform
> supported by Linux mainline kernel and devicetree files.
> 
> Signed-off-by: Jyri Sarha <jsarha at ti.com>
> ---
>  .../bindings/display/tilcdc/panel.txt         | 20 +++++---
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c          | 50 +++++--------------
>  drivers/gpu/drm/tilcdc/tilcdc_drv.h           | 27 ----------
>  drivers/gpu/drm/tilcdc/tilcdc_external.c      | 16 ------
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c         |  9 ----
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c        |  8 ---
>  6 files changed, 24 insertions(+), 106 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt
> index 808216310ea2..b3d63e3db714 100644
> --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt
> +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt
> @@ -3,15 +3,19 @@ Device-Tree bindings for tilcdc DRM generic panel output driver
>  Required properties:
>   - compatible: value should be "ti,tilcdc,panel".
>   - panel-info: configuration info to configure LCDC correctly for the panel
> -   - ac-bias: AC Bias Pin Frequency
> -   - ac-bias-intrpt: AC Bias Pin Transitions per Interrupt
> -   - dma-burst-sz: DMA burst size
> -   - bpp: Bits per pixel
> -   - fdd: FIFO DMA Request Delay
>     - sync-edge: Horizontal and Vertical Sync Edge: 0=rising 1=falling
> -   - sync-ctrl: Horizontal and Vertical Sync: Control: 0=ignore
> -   - raster-order: Raster Data Order Select: 1=Most-to-least 0=Least-to-most
> -   - fifo-th: DMA FIFO threshold

Removing all these sounds ok to me, as long as no existing board breaks.
Many of these are clearly something that's not supposed to be in DT. I
think only the bpp and sync-ctrl are something that might have a place
in DT.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki