[Intel-gfx] [PATCH v14 03/32] drm/i915: MEI interface implementation
kbuild test robot
lkp at intel.com
Sat Feb 16 03:28:17 UTC 2019
Hi Ramalingam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20190215]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ramalingam-C/drm-i915-Implement-HDCP2-2/20190216-090245
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-l1-02160931 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/drm/i915_component.h:27:0,
from drivers/gpu/drm/i915/intel_hdcp.c:10:
>> include/drm/drm_audio_component.h:22:27: warning: 'struct device' declared inside parameter list
void (*get_power)(struct device *);
^
>> include/drm/drm_audio_component.h:22:27: warning: its scope is only this definition or declaration, which is probably not what you want
include/drm/drm_audio_component.h:28:27: warning: 'struct device' declared inside parameter list
void (*put_power)(struct device *);
^
include/drm/drm_audio_component.h:32:37: warning: 'struct device' declared inside parameter list
void (*codec_wake_override)(struct device *, bool enable);
^
include/drm/drm_audio_component.h:36:31: warning: 'struct device' declared inside parameter list
int (*get_cdclk_freq)(struct device *);
^
include/drm/drm_audio_component.h:43:32: warning: 'struct device' declared inside parameter list
int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);
^
include/drm/drm_audio_component.h:57:10: warning: 'struct device' declared inside parameter list
unsigned char *buf, int max_bytes);
^
include/drm/drm_audio_component.h:90:48: warning: 'struct device' declared inside parameter list
int (*master_bind)(struct device *dev, struct drm_audio_component *);
^
include/drm/drm_audio_component.h:97:51: warning: 'struct device' declared inside parameter list
void (*master_unbind)(struct device *dev, struct drm_audio_component *);
^
In file included from drivers/gpu/drm/i915/intel_drv.h:34:0,
from drivers/gpu/drm/i915/intel_hdcp.c:15:
drivers/gpu/drm/i915/i915_drv.h:58:41: fatal error: drm/i915_mei_hdcp_interface.h: No such file or directory
compilation terminated.
--
In file included from include/drm/i915_component.h:27:0,
from drivers/gpu//drm/i915/intel_hdcp.c:10:
>> include/drm/drm_audio_component.h:22:27: warning: 'struct device' declared inside parameter list
void (*get_power)(struct device *);
^
>> include/drm/drm_audio_component.h:22:27: warning: its scope is only this definition or declaration, which is probably not what you want
include/drm/drm_audio_component.h:28:27: warning: 'struct device' declared inside parameter list
void (*put_power)(struct device *);
^
include/drm/drm_audio_component.h:32:37: warning: 'struct device' declared inside parameter list
void (*codec_wake_override)(struct device *, bool enable);
^
include/drm/drm_audio_component.h:36:31: warning: 'struct device' declared inside parameter list
int (*get_cdclk_freq)(struct device *);
^
include/drm/drm_audio_component.h:43:32: warning: 'struct device' declared inside parameter list
int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);
^
include/drm/drm_audio_component.h:57:10: warning: 'struct device' declared inside parameter list
unsigned char *buf, int max_bytes);
^
include/drm/drm_audio_component.h:90:48: warning: 'struct device' declared inside parameter list
int (*master_bind)(struct device *dev, struct drm_audio_component *);
^
include/drm/drm_audio_component.h:97:51: warning: 'struct device' declared inside parameter list
void (*master_unbind)(struct device *dev, struct drm_audio_component *);
^
In file included from drivers/gpu//drm/i915/intel_drv.h:34:0,
from drivers/gpu//drm/i915/intel_hdcp.c:15:
drivers/gpu//drm/i915/i915_drv.h:58:41: fatal error: drm/i915_mei_hdcp_interface.h: No such file or directory
compilation terminated.
vim +22 include/drm/drm_audio_component.h
a57942bf Takashi Iwai 2018-07-11 8
ae891abe Takashi Iwai 2018-07-11 9 /**
ae891abe Takashi Iwai 2018-07-11 10 * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
ae891abe Takashi Iwai 2018-07-11 11 */
ae891abe Takashi Iwai 2018-07-11 12 struct drm_audio_component_ops {
ae891abe Takashi Iwai 2018-07-11 13 /**
ae891abe Takashi Iwai 2018-07-11 14 * @owner: drm module to pin down
ae891abe Takashi Iwai 2018-07-11 15 */
ae891abe Takashi Iwai 2018-07-11 16 struct module *owner;
ae891abe Takashi Iwai 2018-07-11 17 /**
ae891abe Takashi Iwai 2018-07-11 18 * @get_power: get the POWER_DOMAIN_AUDIO power well
ae891abe Takashi Iwai 2018-07-11 19 *
ae891abe Takashi Iwai 2018-07-11 20 * Request the power well to be turned on.
ae891abe Takashi Iwai 2018-07-11 21 */
ae891abe Takashi Iwai 2018-07-11 @22 void (*get_power)(struct device *);
ae891abe Takashi Iwai 2018-07-11 23 /**
ae891abe Takashi Iwai 2018-07-11 24 * @put_power: put the POWER_DOMAIN_AUDIO power well
ae891abe Takashi Iwai 2018-07-11 25 *
ae891abe Takashi Iwai 2018-07-11 26 * Allow the power well to be turned off.
ae891abe Takashi Iwai 2018-07-11 27 */
ae891abe Takashi Iwai 2018-07-11 28 void (*put_power)(struct device *);
ae891abe Takashi Iwai 2018-07-11 29 /**
ae891abe Takashi Iwai 2018-07-11 30 * @codec_wake_override: Enable/disable codec wake signal
ae891abe Takashi Iwai 2018-07-11 31 */
ae891abe Takashi Iwai 2018-07-11 32 void (*codec_wake_override)(struct device *, bool enable);
ae891abe Takashi Iwai 2018-07-11 33 /**
ae891abe Takashi Iwai 2018-07-11 34 * @get_cdclk_freq: Get the Core Display Clock in kHz
ae891abe Takashi Iwai 2018-07-11 35 */
ae891abe Takashi Iwai 2018-07-11 36 int (*get_cdclk_freq)(struct device *);
ae891abe Takashi Iwai 2018-07-11 37 /**
ae891abe Takashi Iwai 2018-07-11 38 * @sync_audio_rate: set n/cts based on the sample rate
ae891abe Takashi Iwai 2018-07-11 39 *
ae891abe Takashi Iwai 2018-07-11 40 * Called from audio driver. After audio driver sets the
ae891abe Takashi Iwai 2018-07-11 41 * sample rate, it will call this function to set n/cts
ae891abe Takashi Iwai 2018-07-11 42 */
ae891abe Takashi Iwai 2018-07-11 43 int (*sync_audio_rate)(struct device *, int port, int pipe, int rate);
ae891abe Takashi Iwai 2018-07-11 44 /**
ae891abe Takashi Iwai 2018-07-11 45 * @get_eld: fill the audio state and ELD bytes for the given port
ae891abe Takashi Iwai 2018-07-11 46 *
ae891abe Takashi Iwai 2018-07-11 47 * Called from audio driver to get the HDMI/DP audio state of the given
ae891abe Takashi Iwai 2018-07-11 48 * digital port, and also fetch ELD bytes to the given pointer.
ae891abe Takashi Iwai 2018-07-11 49 *
ae891abe Takashi Iwai 2018-07-11 50 * It returns the byte size of the original ELD (not the actually
ae891abe Takashi Iwai 2018-07-11 51 * copied size), zero for an invalid ELD, or a negative error code.
ae891abe Takashi Iwai 2018-07-11 52 *
ae891abe Takashi Iwai 2018-07-11 53 * Note that the returned size may be over @max_bytes. Then it
ae891abe Takashi Iwai 2018-07-11 54 * implies that only a part of ELD has been copied to the buffer.
ae891abe Takashi Iwai 2018-07-11 55 */
ae891abe Takashi Iwai 2018-07-11 56 int (*get_eld)(struct device *, int port, int pipe, bool *enabled,
ae891abe Takashi Iwai 2018-07-11 57 unsigned char *buf, int max_bytes);
ae891abe Takashi Iwai 2018-07-11 58 };
ae891abe Takashi Iwai 2018-07-11 59
:::::: The code at line 22 was first introduced by commit
:::::: ae891abe7c2ccf75b69ca8330225e37ecc06924e drm/i915: Split audio component to a generic type
:::::: TO: Takashi Iwai <tiwai at suse.de>
:::::: CC: Takashi Iwai <tiwai at suse.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30231 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20190216/a4c73915/attachment-0001.gz>
More information about the dri-devel
mailing list