[PATCH] video/macfb: Remove redundant code

Geert Uytterhoeven geert at linux-m68k.org
Fri Feb 15 08:25:12 UTC 2019


On Fri, Feb 15, 2019 at 3:19 AM Finn Thain <fthain at telegraphics.com.au> wrote:
> The value of info->var.bits_per_pixel get checked in macfb_setcolreg().
> Remove additional checks as they are redundant.
>
> macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct
> initializer. Remove redundant assignments.
>
> macfb_defined.bits_per_pixel, .width and .height all get assigned
> unconditionally. Remove redundant initializers.
>
> Cc: linux-m68k at lists.linux-m68k.org
> Tested-by: Stan Johnson <userm57 at yahoo.com>
> Signed-off-by: Finn Thain <fthain at telegraphics.com.au>

Reviewed-by: Geert Uytterhoeven <geert at linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the dri-devel mailing list