[PATCH RESEND 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

David Santamaría Rogado howl.nsp at gmail.com
Mon Feb 18 23:37:51 UTC 2019


OK, I think I did it right, rebase two commits and ammeded both and
now resend. This one has been attached to this thread but number 2 has
been in a new thread.

El mar., 19 feb. 2019 a las 0:35, David Santamaría Rogado
(<howl.nsp at gmail.com>) escribió:
>
> The (void *) casting in the driver_data variable assignment is superfluous.
> Spotted by Jani Nikula.
>
> Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 52e445bb1aa5..61d3361381b7 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
>                 },
> -               .driver_data = (void *)&acer_s1003,
> +               .driver_data = &acer_s1003,
>         }, {    /* Asus T100HA */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"),
>                 },
> -               .driver_data = (void *)&asus_t100ha,
> +               .driver_data = &asus_t100ha,
>         }, {    /*
>                  * GPD Pocket, note that the the DMI data is less generic then
>                  * it seems, devices with a board-vendor of "AMI Corporation"
> @@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
>                 },
> -               .driver_data = (void *)&gpd_pocket,
> +               .driver_data = &gpd_pocket,
>         }, {    /* GPD Win (same note on DMI match as GPD Pocket) */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
> @@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
>                 },
> -               .driver_data = (void *)&gpd_win,
> +               .driver_data = &gpd_win,
>         }, {    /* GPD Win 2 (too generic strings, also match on bios date) */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
> @@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
>                   DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
>                 },
> -               .driver_data = (void *)&gpd_win2,
> +               .driver_data = &gpd_win2,
>         }, {    /* I.T.Works TW891 */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
> @@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."),
>                   DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"),
>                 },
> -               .driver_data = (void *)&itworks_tw891,
> +               .driver_data = &itworks_tw891,
>         }, {    /*
>                  * Lenovo Ideapad Miix 310 laptop, only some production batches
>                  * have a portrait screen, the resolution checks makes the quirk
> @@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = {
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
>                 },
> -               .driver_data = (void *)&lcd800x1280_rightside_up,
> +               .driver_data = &lcd800x1280_rightside_up,
>         }, {    /* Lenovo Ideapad Miix 320 */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
>                 },
> -               .driver_data = (void *)&lcd800x1280_rightside_up,
> +               .driver_data = &lcd800x1280_rightside_up,
>         }, {    /* VIOS LTH17 */
>                 .matches = {
>                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
>                 },
> -               .driver_data = (void *)&lcd800x1280_rightside_up,
> +               .driver_data = &lcd800x1280_rightside_up,
>         },
>         {}
>  };
> --
> 2.20.1
>


More information about the dri-devel mailing list