[PATCH] staging/vboxvideo: Another FIXME item
Daniel Vetter
daniel.vetter at ffwll.ch
Thu Feb 21 15:59:51 UTC 2019
Found while grepping around.
Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Cc: Hans de Goede <hdegoede at redhat.com>
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Cc: Sam Ravnborg <sam at ravnborg.org>
Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Cc: Liviu Dudau <liviu.dudau at arm.com>
---
drivers/staging/vboxvideo/vbox_irq.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c
index 195484713365..89944134ea86 100644
--- a/drivers/staging/vboxvideo/vbox_irq.c
+++ b/drivers/staging/vboxvideo/vbox_irq.c
@@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox)
validate_or_set_position_hints(vbox);
drm_modeset_lock_all(dev);
+ /*
+ * FIXME: this needs to use drm_connector_list_iter and some real
+ * locking for the actual data it changes, not the deprecated
+ * drm_modeset_lock_all() shotgun approach.
+ */
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
vbox_conn = to_vbox_connector(connector);
--
2.20.1
More information about the dri-devel
mailing list