[PATCH v4 1/2] drm: move i915_kick_out_vgacon to vgaarb

[Gerd Hoffmann]

  Hi,

> > -	/*
> > -	 * WARNING: Apparently we must kick fbdev drivers before vgacon,
> > -	 * otherwise the vga fbdev driver falls over.
> > -	 */
> >  	ret = i915_kick_out_firmware_fb(dev_priv);
> 
> This needs to be replaced with a call to
> drm_fb_helper_remove_conflicting_pci_framebuffers, because the above
> wrapper hasn't been converted yet. Otherwise you end up removing the
> vgacon unbind from i915.

Ah, little but important difference I didn't notice on the first look.
That wrapper calls the non-pci version.  But seems it isn't that easy
to switch over because the framebuffer is in stolen memory instead of a
pci bar ...

> >  	if (ret) {
> >  		DRM_ERROR("failed to remove conflicting framebuffer drivers\n");
> >  		goto err_ggtt;
> >  	}
> >  
> > -	ret = i915_kick_out_vgacon(dev_priv);

... but we can continue to just call vga_remove_vgacon() here.

> Asides from the comments, lgtm. Of course we'll need intel-gfx-ci to
> approve too :-) Please cc intel-gfx on the next version for the entire
> patcheset (our CI doesn't pick up incomplete patchesets).

Ok, will do.

cheers,
  Gerd