[PATCH v3] drm/rockchip: Fix YUV buffers color rendering

Heiko Stuebner heiko at sntech.de
Thu Jan 10 22:55:10 UTC 2019


Am Dienstag, 8. Januar 2019, 22:46:59 CET schrieb Ezequiel Garcia:
> From: Daniele Castagna <dcastagna at chromium.org>
> 
> Currently, YUV hardware overlays are converted to RGB using
> a color space conversion different than BT.601.
> 
> The result is that colors of e.g. NV12 buffers don't match
> colors of YUV hardware overlays.
> 
> In order to fix this, enable YUV2YUV and set appropriate coefficients
> for formats such as NV12 to be displayed correctly.
> 
> This commit was tested using modetest, gstreamer and chromeos (hardware
> accelerated video playback). Before the commit, tests rendering
> with NV12 format resulted in colors not displayed correctly.
> 
> Test examples (Tested on RK3399 and RK3288 boards connected to HDMI monitor):
> 
>   $ modetest 39 at 32:1920x1080 at NV12
>   $ gst-launch-1.0 videotestrc ! video/x-raw,format=NV12 ! kmssink
> 
> Signed-off-by: Daniele Castagna <dcastagna at chromium.org>
> [ezequiel: rebase on linux-next and massage commit log]
> Signed-off-by: Ezequiel Garcia <ezequiel at collabora.com>
> ---
> v3: Add a check for non-null win_yuv2yuv as suggested by Heiko.

applied to drm-misc-next after making sure that display keeps
working on all rockchip socs now

Thanks
Heiko




More information about the dri-devel mailing list