[PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues
Peter Rosin
peda at axentia.se
Thu Jan 10 15:10:28 UTC 2019
Hi!
I found an unfortunate issue while recoding plane handling to use
drm_atomic_helper_check_plane_state(). The driver rotates clockwise,
which is not correct. I simply fixed it (patch 1/4), but maybe that
will cause regressions for unsuspecting users who simply assumed
that the clockwise rotation was correct? I don't know what to do
about that? Adding an option to get the old broken behavior seems
useless, wouldn't it be just as easy to just fix whatever app to
rotate the other way instead of adding an option somewhere?
I have only tested this series on sama5d3, but I did check the docs
for various other chips (sama5d2, sama5d4, sam9n12, sam9g15, sam9g35
and sam9x35) supported by the driver (relevant to patch 4/4).
Cheers,
Peter
Peter Rosin (4):
drm/atmel-hlcdc: rotate planes counterclockwise
drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated
drm/atmel-hlcdc: fix clipping of planes
drm/atmel-hlcdc: do not immediately disable planes, wait for next
frame
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 179 +++++++++---------------
1 file changed, 67 insertions(+), 112 deletions(-)
--
2.11.0
More information about the dri-devel
mailing list